[codex] Expose deploy config mechanics#61
Closed
xu16601526267 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes three product-mechanism issues that made AIMA deploy troubleshooting hard to trust:
deploy.dry_runresolved catalog/default config from the effective config afterCheckFitruntime adjustmentsDetails
deploy.dry_runnow keeps the legacyconfigfield as the effective deployment config for compatibility, while also addingresolved_config,effective_config,fit_adjustments,resolved_provenance, andeffective_provenance. This prevents UI/agent callers from confusing catalog defaults with resource-driven automatic adjustments.Runtime flag generation now accepts catalog model type and engine context. LLM knobs like
max_model_len,gpu_memory_utilization, andmem_fraction_staticare preserved for LLM/vLLM/SGLang-style commands, but are not passed into service wrappers that do not expose those flags.system.status,system.diagnostics, andcatalog statusnow include service context such asdata_dir,overlay_dir, catalog load time, latest overlay mtime, and a reload hint when overlays changed after the process loaded the catalog.Validation
Passed:
go test ./internal/knowledgego test ./internal/runtime -run "TestConfigToFlags" -count=1go test ./cmd/aima -run "TestResolveDeploymentKeepsResolvedAndEffectiveConfigSeparate|TestServiceContextReportsStaleOverlayHint" -count=1git diff --checkKnown local Windows environment failures when running
go test ./internal/knowledge ./internal/runtime ./cmd/aima:TestBuildRunArgs_ModelFileVolumeexpects Unix/mnt/...Docker volume formatting but the test ran under Windows pathsTestResolveLocalModelPathNoPullUsesSymlinkMirrorSourcecannot create symlinks without elevated Windows privileges